Disable mandatory TLS verification with --insecure #1401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d4xfe Thank you, looks excellent considering this is your first PR. Congratulations. Can you please:
|
abhinavsingh
added
the
bot:chronographer:skip
|
@abhinavsingh Thanks. I've synced the branches and I don't conflicts anymore. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1401 +/- ##
===========================================
- Coverage 84.57% 84.37% -0.20%
===========================================
Files 177 178 +1
Lines 8103 8130 +27
Branches 1239 1242 +3
===========================================
+ Hits 6853 6860 +7
- Misses 1052 1059 +7
- Partials 198 211 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@d4xfe Thank you for this work and the PR. There are some workflow issues. I am going create a new PR based on top of your contribution and try to this ship. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getpeercert()only returns the certificate with enabled certificate validation. Because of this, I updated it togetpeercert(True), which will return a binary blob of the servers certificate regardless of the verification mode.I added the util method
cert_der_to_dictusingsslinternals to convert the blob to a python dict likegetpeercert()would.The flag
--insecurewas introduced to disable certificate validation of ssl sockets.This allows TLS interception when the server is using a self-signed certificate.
This is my first pull request on GitHub and I'm still a bit confused. So if I should change anything let me know.